Skip to content

Comments

fix:#664 Fix failing tests in CreateGroup page and EditGroup page#665

Merged
tonyb650 merged 1 commit intodevelopfrom
tony/664-tests-failing-CreateGroupPage
Nov 3, 2025
Merged

fix:#664 Fix failing tests in CreateGroup page and EditGroup page#665
tonyb650 merged 1 commit intodevelopfrom
tony/664-tests-failing-CreateGroupPage

Conversation

@tonyb650
Copy link
Contributor

@tonyb650 tonyb650 commented Nov 1, 2025

Description

Before:

Two unit tests were failing because they were reliant on the actual system date.

After:

The date for the tests is now mocked and the Calendar component will be rendered consistently in these tests.

Closes #664

Additional information

Moved the past, today, and tomorrow dates to the middle of the month to avoid the potential duplicate days that may occur near the beginning and end of the calendar display.

Pre-submission checklist

  • Code builds and passes locally
  • PR title follows Conventional Commit format (e.g. test #001: created unit test for __ component)
  • Request reviews from the Peer Code Reviewers and Senior+ Code Reviewers groups
  • Thread has been created in Discord and PR is linked in gis-code-questions

Copilot AI review requested due to automatic review settings November 1, 2025 21:58
@shashilo shashilo requested review from a team, Yassahr and bethanyann and removed request for a team, bethanyann, Copilot, nickytonline and shashilo November 1, 2025 21:58
@vercel
Copy link

vercel bot commented Nov 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elecretanta Ready Ready Preview Comment Nov 1, 2025 9:58pm
elecretanta-storybook Ready Ready Preview Comment Nov 1, 2025 9:58pm
elecretanta-unit-test Ready Ready Preview Comment Nov 1, 2025 9:58pm

@tonyb650 tonyb650 merged commit f26e4dd into develop Nov 3, 2025
11 checks passed
@tonyb650 tonyb650 deleted the tony/664-tests-failing-CreateGroupPage branch November 3, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing in CreateGroupPage

3 participants