fix:#653 Remove default dates from CreateGroup and EditGroup pages day picker#680
Merged
fix:#653 Remove default dates from CreateGroup and EditGroup pages day picker#680
Conversation
tonyb650
requested review from
bethanyann,
nickytonline and
shashilo
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shashilo
requested review from
a team,
bethanyann and
jefische
and removed request for
a team,
bethanyann,
Copilot,
nickytonline and
shashilo
bethanyann
approved these changes
Nov 12, 2025
jefische
approved these changes
Nov 12, 2025
Contributor
jefische
left a comment
jefische
left a comment
There was a problem hiding this comment.
Looks solid! All is working well when testing both the create group and edit group calendars. I don't see any changes needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before:
Having a pre-defined default date led to a bug where clicking on the same day (today) would set the form state for that date picker / form field to
undefinedinstead of the correct date.After:
Removed the default date in the form state for both the Drawing Date and the Exchange Date. Now the form cannot be submitted without a date being selected.
Also, improved the behavior of the Exchange Date picker so that "today" is disabled; "tomorrow" is the first choice that is enabled.
Closes #653
Pre-submission checklist
test #001: created unit test for __ component)Peer Code ReviewersandSenior+ Code Reviewersgroupsgis-code-questions