Skip to content

Refactor: use async/await in closeResources() #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vweevers merged 1 commit into from
Dec 31, 2024
Merged

Refactor: use async/await in closeResources() #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions abstract-level.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,23 +291,20 @@ class AbstractLevel extends EventEmitter {
// In parallel so that all resources know they are closed
const resources = Array.from(this.#resources)
const promises = resources.map(closeResource)

// TODO: async/await
return Promise.allSettled(promises).then(async (results) => {
const errors = []

for (let i = 0; i < results.length; i++) {
if (results[i].status === 'fulfilled') {
this.#resources.delete(resources[i])
} else {
errors.push(convertRejection(results[i].reason))
}
const results = await Promise.allSettled(promises)
const errors = []

for (let i = 0; i < results.length; i++) {
if (results[i].status === 'fulfilled') {
this.#resources.delete(resources[i])
} else {
errors.push(convertRejection(results[i].reason))
}
}

if (errors.length > 0) {
throw combineErrors(errors)
}
})
if (errors.length > 0) {
throw combineErrors(errors)
}
}

async _close () {}
Expand Down
Loading