Add db.getSync() method
#120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
enhancement
6 tasks
Also optimizes `db.get()` to avoid a copy of the key if it's a buffer. Relies on a patch to LevelDB that replaces use of `std::string` with a new ValueSink struct that gives us more control over the memory. Ref: Level/community#144 Category: addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also optimizes
db.get()to avoid a copy of the key if it's a buffer. Relies on a patch to LevelDB that replaces use ofstd::stringwith a new ValueSink struct that gives us more control over the memory.Depends on Level/abstract-level#114.
Ref: Level/community#144