-
Notifications
You must be signed in to change notification settings - Fork 1
Fix /confirmclear being listed as /clearconfirm, add multiple missing commands #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThree documentation files updated to rename the inventory-clear toggle command from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @Writerside/topics/ES-Commands.md:
- Line 49: Update the empty Markdown link in the /confirmclear table row so it
includes descriptive link text; replace [](ES-Inventory.md) with meaningful text
such as [ES Inventory](ES-Inventory.md) or [see ES Inventory
topic](ES-Inventory.md) in the table cell for the /confirmclear entry.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Writerside/topics/ES-Changelogs.mdWriterside/topics/ES-Commands.mdWriterside/topics/ES-Inventory.md
🔇 Additional comments (6)
Writerside/topics/ES-Inventory.md (1)
34-34: Command name updates are consistent across documentation.Both references to the toggle command for inventory clearing have been correctly updated from
/clearconfirmto/confirmclear, aligning with the broader command rename documented in the changelog.Also applies to: 40-40
Writerside/topics/ES-Commands.md (4)
88-89: New teleportation commands properly documented.Both
/ascendand/descendfollow the established command documentation pattern with consistent permissions naming (essence.teleport.*), clear descriptions, and correct console access settings.
96-96: Permission requirement note is clearly stated.The addition of the
essence.warp.delete.otherpermission requirement appropriately documents an important distinction for warp management and is well-positioned within the Warp Commands section.
121-121: Capitalization update improves header consistency.The "Spawn Commands" header now matches the capitalization pattern of all other command section headers (e.g., "Gamemode Commands", "Inventory Commands", "Teleportation Commands").
130-136: New Orientation Commands section is well-structured.The section introduction properly defines the wildcard permission and includes both new commands in a table consistent with other command sections. The permission names follow established patterns (
essence.orientation.*), and descriptions are clear.Writerside/topics/ES-Changelogs.md (1)
23-23: Changelog accurately reflects command additions.The 1.11.0 Added section correctly lists
/confirmclearand includes all new commands documented in ES-Commands.md (/ascend,/descend,/direction,/near), maintaining consistency across the documentation.
|
Thank you!
It should be in there, I must've missed it. If I have chance tomorrow I'll pop it in :) |
This PR:
/confirmclearbeing listed as/clearconfirmin multiple places/ascend&/descendunder General Teleportationessence.warp.delete.otherto Warp Commands/directionand/nearHopefully this is everything that was missing or incorrect.
I assume the reason
/worldisn't listed anywhere in the Commands list (and doesn't have its own category there) is because of the separate page for it under Features?I started to add it, but then realized the above + it's just one command with lots of sub-commands, so it doesn't quite fit the consistency of the Commands page.
Thanks for looking at this, I know you're busy with exams and such :)
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.