A bundle of minor improvements #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Use the compiler's `Printtyp.type_expr` function instead of redefining it. WARNING : ensure this is compatible with LexiFi's internal compiler. + Change name from `_TO_STRING_` (unconventional) to `to_string`
+ Use clearer functions and parameters + Break large patterns in smaller more comprehensible ones + Add some comments on unclear code + Improve the API and its comments
+ `eom` is now `eof` (end of file) + `later` is now `at_eof` + `last` is `at_eocb` (end of codebase) + add comments for `eof` in `.mli`s
The `find` function was expecting a `ref` for the `occur` parameter although it is always passed (updated) as argument to its inner `loop` function.
fantazio
force-pushed
the
maintenance
branch
from
e1c2146 to
08c6de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/deadArg.ml)DeadType.to_string