-
Notifications
You must be signed in to change notification settings - Fork 31
Support for primitives bindings #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I've tried to update the PR with the latest change from jsoo ocsigen/js_of_ocaml#2086 (see branch https://github.com/hhugo/gen_js_api/tree/runtime-primitives-bindings-hh). |
|
This new feature needs to be documented |
I think you just need to replace the occurrences of |
|
@hhugo I cherry-picked your branch, adapted the PR and document the new features, I'll wait ocsigen/js_of_ocaml#2086 to merge this and make a new release of gen_js_api. |
ocsigen/js_of_ocaml#2086 has been merged ! @hhugo: can we expect a release of JSOO soon? |
|
Gentle reminder |
|
Gentle ping |
Description
This PR adds support for a new attribute [@js.runtime "string"] that allows bindings a js_of_ocaml pritimitive using
Jsoo_runtime.Sys.external_from ocsigen/js_of_ocaml#2086For instance:
expands to
I also added an extension of the existing "js.scope" attribute by adding an "@" to the parameter you can refer to a runtime primitive.
Example:
expands to