Open
Conversation
added 7 commits
December 31, 2025 10:56
…rn. rfbClientIteratorNext decrements the reference of the current node and increments the next one. However, rfbClientIteratorHead was only performing a decrement on the existing i->next, but not performing an increment when setting the new i->next from screen->clientHead.
This led to a negative refCount (e.g., -1, -2, -3) because the subsequent call to rfbClientIteratorNext in rfbProcessEvents would attempt to decrement a reference that was never legally "taken."
rfbProcessEvents
cl = rfbClientIteratorHead(i) ----i->next=i->screen->clientHead;
while(cl)
{
cl=rfbClientIteratorNext(i); -----i->next !=0 ----->rfbDecrClientRef(cl);
}
Signed-off-by: 14067 <yanzt@sugon.com>
…rn. rfbClientIteratorNext decrements the reference of the current node and increments the next one. However, rfbClientIteratorHead was only performing a decrement on the existing i->next, but not performing an increment when setting the new i->next from screen->clientHead.
This led to a negative refCount (e.g., -1, -2, -3) because the subsequent call to rfbClientIteratorNext in rfbProcessEvents would attempt to decrement a reference that was never legally "taken."
rfbProcessEvents
cl = rfbClientIteratorHead(i) ----i->next=i->screen->clientHead;
while(cl)
{
cl=rfbClientIteratorNext(i); -----i->next !=0 ----->rfbDecrClientRef(cl);
}
Signed-off-by: 14067 <yanzt@sugon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rn. rfbClientIteratorNext decrements the reference of the current node and increments the next one. However, rfbClientIteratorHead was only performing a decrement on the existing i->next, but not performing an increment when setting the new i->next from screen->clientHead.
This led to a negative refCount (e.g., -1, -2, -3) because the subsequent call to rfbClientIteratorNext in rfbProcessEvents would attempt to decrement a reference that was never legally "taken."
rfbProcessEvents
cl = rfbClientIteratorHead(i) ----i->next=i->screen->clientHead;
while(cl)
{
cl=rfbClientIteratorNext(i); -----i->next !=0 ----->rfbDecrClientRef(cl);
}