Implement self-signed TLS certificate handling for GnuTLS backend#689
Draft
Implement self-signed TLS certificate handling for GnuTLS backend#689
Conversation
Co-authored-by: bk138 <80450+bk138@users.noreply.github.com>
Co-authored-by: bk138 <80450+bk138@users.noreply.github.com>
Co-authored-by: bk138 <80450+bk138@users.noreply.github.com>
Co-authored-by: bk138 <80450+bk138@users.noreply.github.com>
Co-authored-by: bk138 <80450+bk138@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement handling of self-signed TLS certs for gnutls backend
Implement self-signed TLS certificate handling for GnuTLS backend
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GnuTLS backend lacked support for self-signed certificates, forcing clients to fail on untrusted CAs. This brings it to parity with the OpenSSL backend.
Changes
cert_fingerprint_mismatch_callback: Extracts certificate subject, validity times, and SHA-256 fingerprint, then invokes the existingGetX509CertFingerprintMismatchDecisioncallback for user acceptanceverify_certificate_callback: On system CA validation failure, compares remote fingerprint against expected fingerprint (if provided), otherwise delegates to user callbackrfbTLSVerifyDatastructure: Passes both expected fingerprint and client pointer through the GnuTLS verification chainHandleVeNCryptAuth: Allocates and passes verification data to callback, with proper cleanup post-handshakeFreeX509Credential: Freesx509ExpectedFingerprintfieldUsage
No API changes required. Clients using
GetX509CertFingerprintMismatchDecisioncallback now work with GnuTLS backend:The credential structure's
x509ExpectedFingerprintfield is now honored for fingerprint pinning with GnuTLS.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.