Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cmake-linux-amd64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
id: strings
run: |
echo "build-output-dir=${{github.workspace}}/build" >> "$GITHUB_OUTPUT"
echo "/home/cudeiro/cmake-4.2.1-linux-x86_64/bin/" >> "$GITHUB_PATH"
echo "$HOME/cmake-4.2.1-linux-x86_64/bin/" >> "$GITHUB_PATH"
echo "CUDACXX=/usr/local/cuda-${{matrix.cuda_toolkit}}/bin/nvcc" >> "$GITHUB_ENV"
echo "CC=${{matrix.host_compiler}}" >> "$GITHUB_ENV"
echo "CXX=${{matrix.host_compiler}}" >> "$GITHUB_ENV"
Expand Down
17 changes: 13 additions & 4 deletions .github/workflows/cmake-linux-arm64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,30 @@ jobs:
include:
- host_compiler: "g++-11"
cuda_toolkit: "12.9"
cuda_ldpath: "cuda-12.9"
Comment on lines 20 to +22
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matrix value cuda_ldpath: "cuda-12.9" expands to /usr/local/cuda-12.9 in LD_LIBRARY_PATH, but CUDA shared libraries are typically under a lib directory (e.g., targets/aarch64-linux/lib / lib64) rather than the toolkit root. If this variable is meant to make runtime linking work, it should point at the directory that actually contains the .so files.

Copilot uses AI. Check for mistakes.
- host_compiler: "clang++-21"
cuda_toolkit: "12.9"
#
cuda_ldpath: "cuda-12.9"
- host_compiler: "g++-11"
cuda_toolkit: "13.2"
cuda_ldpath: "cuda-13.2/compat_orin"
- host_compiler: "clang++-21"
cuda_toolkit: "13.2"
cuda_ldpath: "cuda-13.2/compat_orin"
Comment on lines +26 to +31
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuda_ldpath values point at CUDA install roots (e.g. /usr/local/cuda-12.9 and /usr/local/cuda-13.2/compat_orin). LD_LIBRARY_PATH needs directories that directly contain the shared libraries (commonly .../lib64 or .../targets/aarch64-linux/lib, and for the compatibility package likely a .../lib subdir). As-is, the dynamic loader won’t search subdirectories, so runtime/test steps may fail to locate CUDA libs. Consider changing cuda_ldpath to the actual library directory paths for each toolkit/compat combo.

Copilot uses AI. Check for mistakes.

steps:
- uses: actions/checkout@v4
- name: Set reusable strings
# Turn repeated input strings (such as the build output directory) into step outputs. These step outputs can be used throughout the workflow file.
id: strings
run: |
echo "build-output-dir=${{github.workspace}}/build" >> "$GITHUB_OUTPUT"
echo "/home/cudeiro/cmake-4.2.1-linux-aarch64/bin/" >> "$GITHUB_PATH"
echo "$HOME/cmake-4.2.1-linux-aarch64/bin/" >> "$GITHUB_PATH"
echo "CUDACXX=/usr/local/cuda-${{matrix.cuda_toolkit}}/bin/nvcc" >> "$GITHUB_ENV"
echo "CC=${{matrix.host_compiler}}" >> "$GITHUB_ENV"
echo "CXX=${{matrix.host_compiler}}" >> "$GITHUB_ENV"

echo "CXX=${{matrix.host_compiler}}" >> "$GITHUB_ENV"
echo "LD_LIBRARY_PATH=/usr/local/${{matrix.cuda_ldpath}}:$LD_LIBRARY_PATH" >> "$GITHUB_ENV"
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting LD_LIBRARY_PATH as "/usr/local/...:$LD_LIBRARY_PATH" can leave a trailing ':' when LD_LIBRARY_PATH is empty/unset, which causes the dynamic linker to also search the current working directory. Please adjust the append logic so an empty LD_LIBRARY_PATH does not introduce an empty path element (for safety and determinism).

Suggested change
echo "LD_LIBRARY_PATH=/usr/local/${{matrix.cuda_ldpath}}:$LD_LIBRARY_PATH" >> "$GITHUB_ENV"
echo "LD_LIBRARY_PATH=/usr/local/${{matrix.cuda_ldpath}}${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" >> "$GITHUB_ENV"

Copilot uses AI. Check for mistakes.

- name: Configure CMake
run: |

Expand Down
Loading