Skip to content

fix(registration): Resolve a server error when more than one attributes#1109

Merged
JohnVillalovos merged 1 commit intoLibreBooking:developfrom
belcirelk:fix/registration
Mar 7, 2026
Merged

fix(registration): Resolve a server error when more than one attributes#1109
JohnVillalovos merged 1 commit intoLibreBooking:developfrom
belcirelk:fix/registration

Conversation

@belcirelk
Copy link
Copy Markdown
Collaborator

Added a loop in the tpl to display all attributes on the registration page.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the registration page template to render all configured user custom attributes, addressing a server error that occurred when multiple attributes were present.

Changes:

  • Replace single-attribute rendering logic with a {foreach} loop over $Attributes.
  • Minor template formatting adjustment near the footer include.

You can also share your feedback on Copilot code review. Take the survey.

@JohnVillalovos
Copy link
Copy Markdown
Collaborator

I think the unit tests are having problems because daylight savings time is happening in a few days.

Copy link
Copy Markdown
Collaborator

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @belcirelk

LGTM. I will squash it down to one commit for merge.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


You can also share your feedback on Copilot code review. Take the survey.

…es in the register page

Added a loop in the tpl to display all attributes on the registration page.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


You can also share your feedback on Copilot code review. Take the survey.

@JohnVillalovos JohnVillalovos merged commit 71a3f73 into LibreBooking:develop Mar 7, 2026
18 of 19 checks passed
@belcirelk belcirelk deleted the fix/registration branch March 27, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants