Open
Conversation
Signed-off-by: John-Eric Kamps <johnny86@gmx.de>
…devel, nightly, daily, weekly, monthly). No need to set them manually. Signed-off-by: John-Eric Kamps <johnny86@gmx.de>
Signed-off-by: John-Eric Kamps <johnny86@gmx.de>
Member
|
@antonlacon @lrusak could you have a look ? |
antonlacon
reviewed
Jun 7, 2022
Contributor
antonlacon
left a comment
antonlacon
left a comment
There was a problem hiding this comment.
Initial comments from looking at the python usage. I haven't tried parsing the prettyname regex out, or looked at the manual update function in the addon where this gets used yet.
| self._prettyname = args.prettyname | ||
| else: | ||
| self._prettyname = PRETTYNAME | ||
| if args.dev_prettyname: |
Contributor
There was a problem hiding this comment.
This could be an elif at same indent.
| a_maj_min_patch = self._regex_xydate_custom_short_sort.search(a) | ||
|
|
||
| if not a_maj_min_patch: | ||
| raise Exception('ERROR: Filename not like expected') |
Contributor
There was a problem hiding this comment.
An f-string, or similar, to make this exception more useful:
raise Exception(f'ERROR: Unexpected filename: {a}')
| b_maj_min_patch = self._regex_xydate_custom_short_sort.search(b) | ||
|
|
||
| if not b_maj_min_patch: | ||
| raise Exception('ERROR: Filename not like expected') |
|
|
||
| parser.add_argument('-d', '--dev_prettyname', action="store_true", required=False, \ | ||
| help=' Enable prettyname regex for development builds (devel, nightly, daily, weekly, monthly)') | ||
|
|
Contributor
There was a problem hiding this comment.
Leading space in the help string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge the following changes for full development file support and development pretty name support per new argument -d
I checked them with the myself generated files.
Thanks a lot