Skip to content

mounting_holes: Approve library check messages #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ubruhin merged 1 commit into from
Mar 4, 2026
Merged

mounting_holes: Approve library check messages #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion generate_mounting_holes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ def _add_footprint(name: str, pad: bool, cover: bool) -> None:
_add_footprint('covered', pad=False, cover=True)
_add_footprint('blank', pad=False, cover=False)

package.add_approval('(approved ambiguous_footprint_tags)')
package.add_approval('(approved suspicious_assembly_type)')

package.serialize(path.join('out', library, 'pkg'))
Expand Down Expand Up @@ -357,7 +358,7 @@ def _uuid(identifier: str) -> str:
generate_pkg(
library='LibrePCB_Base.lplib',
author='U. Bruhin',
version='0.1',
version='0.1.1',
create_date='2025-04-09T15:07:42Z',
name=name,
hole_diameter=hole_diameter,
Expand Down