[stable32] feat: envelope custom path #6304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow envelopes to be created at user-specified absolute paths. Add getUserRootFolder() and getOrCreateFolderByAbsolutePath() methods to FolderService for path-based folder management with validation. Signed-off-by: Vitor Mattos <[email protected]>
Move EnvelopeService and EnvelopeFileRelocator to Service/Envelope/ namespace for better code organization. Extract file relocation logic from RequestSignatureService into EnvelopeFileRelocator to improve separation of concerns and testability. Signed-off-by: Vitor Mattos <[email protected]>
Add tests for getUserRootFolder() and getOrCreateFolderByAbsolutePath() to validate folder creation, nested paths, and empty folder validation. Signed-off-by: Vitor Mattos <[email protected]>
Add tests covering custom paths (root, nested, with spaces), default naming patterns, empty folder validation, and file count constraints using dataProviders for better test organization. Signed-off-by: Vitor Mattos <[email protected]>
Add tests for file relocation logic validating files are copied into envelope folders when outside, returned as-is when already inside, and proper error handling for invalid nodes. Update namespace references in related test files. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
backport/6302/stable32
branch
from
2b8a35f to
1c5e64a
Compare
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6302
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.