[stable32] feat: envelope sidebar improvements #6307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating envelopes from multiple files, the envelope path is now properly configured based on the parent directory of the selected files. This ensures envelopes are created in the same directory as the source files instead of the root folder. The path is normalized to handle edge cases like root directory and trailing slashes, providing consistent behavior across different file locations. Signed-off-by: Vitor Mattos <[email protected]>
This refactoring enhances the sidebar behavior when working with envelopes and files: - Remove unused data properties (file, signers, requested_by, requestDate) - Add checkAndLoadPendingEnvelope() to handle envelope creation flow - Implement MutationObserver to maintain correct sidebar title - Add title synchronization for both envelopes and regular files - Prevent duplicate file loading when same file is already selected - Ensure proper cleanup of observers to prevent memory leaks The sidebar title now correctly displays the envelope or file name and resists being overwritten by Nextcloud's default behavior. Signed-off-by: Vitor Mattos <[email protected]>
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6305