[stable32] refactor: replace fileid by nodeid at filestore #6311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename selectedId to selectedNodeId in the files store state - Replace all references to selectedId with selectedNodeId throughout files.js - Update selectFile() method to use nodeId parameter - Add getNodeIdByFileId() helper method to map file IDs to node IDs - Remove unused slugfy() helper function - Update async addFile() to handle file hydration properly - Update removeFilesFromEnvelope() to use only fileIds parameter - Fix getAllFiles() and updateAllFiles() to work with nodeId - Ensure backward compatibility with file.id property - Update sign.js to use selectedNodeId from files store Signed-off-by: Vitor Mattos <[email protected]>
- Replace prop 'fileId' with 'nodeId' - Rename computed property 'currentFileId' to 'currentNodeId' - Add new computed property 'currentFile' for cleaner access - Update template to use currentFile instead of inline store access - Simplify DOM binding by using currentFile computed property - Remove unnecessary store property access in template - Fix previewUrl to use currentFile consistently Signed-off-by: Vitor Mattos <[email protected]>
- Replace fileId parameter with nodeId in promise handlers - Update selectFile() calls to receive nodeId instead of fileId - Ensure consistency with new store API Signed-off-by: Vitor Mattos <[email protected]>
- Replace selectedId with selectedNodeId in the comparison - Ensure consistency with updated store structure Signed-off-by: Vitor Mattos <[email protected]>
…roperties - Remove envelopeUuid computed property - Remove envelopeId computed property - Replace all references to use envelope directly from getFile() - Simplify envelope.id and envelope.uuid access - Remove unnecessary envelope property cache - Update removeFilesFromEnvelope() calls to pass only fileIds - Remove redundant file count updates in addFilesToEnvelope - Use consistent nodeId/file.id property naming Signed-off-by: Vitor Mattos <[email protected]>
- Rename data property 'lastSyncedFileId' to 'lastSyncedNodeId' - Update watcher from 'filesStore.selectedId' to 'filesStore.selectedNodeId' - Update handler to work with newNodeId and oldNodeId parameters - Replace fileId parameter with nodeId in sendNotify method - Use getFile().id to get the current file ID when needed Signed-off-by: Vitor Mattos <[email protected]>
- Update file computed property to use source.nodeId instead of source.id - Replace all source.id references with source.nodeId - Update selectFile() calls to pass nodeId Signed-off-by: Vitor Mattos <[email protected]>
- Replace fileId variable with nodeId in selection filter logic - Update selection logic to use source.nodeId instead of source.id - Remove debug log statement for shift key selection - Ensure consistency with store API Signed-off-by: Vitor Mattos <[email protected]>
… loop - Replace fileId with nodeId in changeLoadingStatusOfSelectedFiles method - Update variable naming for consistency Signed-off-by: Vitor Mattos <[email protected]>
- Replace filesStore.selectedId with filesStore.selectedNodeId - Ensure consistency with updated store API Signed-off-by: Vitor Mattos <[email protected]>
- Replace fileId/id with nodeId in initialization loops - Update selectedId with selectedNodeId in store assignments - Fix nodeId parameter usage in file lookups Signed-off-by: Vitor Mattos <[email protected]>
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6309