[stable32] feat: delete empty folders and respect checkbox #6349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional boolean parameter 'deleteFile' (default true) to the DELETE endpoint. This allows clients to control whether physical files should be deleted from Nextcloud or only the LibreSign metadata should be removed. Signed-off-by: Vitor Mattos <[email protected]>
Implement the deleteFile parameter in FileService::delete() method: - When deleteFile=true: remove physical files and empty parent folders - When deleteFile=false: keep physical files, only remove metadata Add deleteEmptyFolder() private method that safely checks and removes empty folders after file deletion. This prevents accumulation of empty directories while handling permission errors gracefully. The deletion is propagated to child files when deleting envelopes. Signed-off-by: Vitor Mattos <[email protected]>
Update files store to send deleteFile parameter as query param when the user chooses to delete files. This connects the UI checkbox to the backend parameter, allowing users to control whether files are deleted from Nextcloud or only the signature request is removed. Signed-off-by: Vitor Mattos <[email protected]>
Add comprehensive unit tests for the new deletion features: - testDeleteRemovesEmptyFolder: validates empty folders are deleted - testDeleteKeepsNonEmptyFolder: ensures folders with files are kept - testDeleteWithoutDeletingFile: verifies metadata-only deletion Refactor test setup to use setUp() method for mock initialization, eliminating duplicate mock creation across tests. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6347