[stable32] refactor: unify signature request methods #6358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace duplicated saveWithVisibleElements and updateSignatureRequest methods with a single saveOrUpdateSignatureRequest method in the files store. This eliminates code duplication and simplifies the API by using a unified method with a status parameter (default 0 for draft, 1 for request). Signed-off-by: Vitor Mattos <[email protected]>
Replace calls to saveWithVisibleElements and updateSignatureRequest with saveOrUpdateSignatureRequest. Remove redundant default parameters (visibleElements: [], status: 0) that are now handled by the method's default values, making the code cleaner and more maintainable. Signed-off-by: Vitor Mattos <[email protected]>
Replace saveWithVisibleElements call with saveOrUpdateSignatureRequest. Remove redundant visibleElements: [] parameter as it's now the default. Signed-off-by: Vitor Mattos <[email protected]>
Replace saveWithVisibleElements call with saveOrUpdateSignatureRequest. Remove redundant status: 0 parameter as it's now the default value. Signed-off-by: Vitor Mattos <[email protected]>
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6356