[stable33] fix: click to sign unauthenticated #6542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes click-to-sign for unauthenticated users by allowing credential retrieval when user is null. Credentials are stored with empty UID for unauthenticated users, so retrieval must use the same pattern. Related to PR #6532
Adds formatEnvelopeChildFilesForSignRequest method to eliminate N+1 queries when formatting multiple sign requests. Pre-loads signers, identify methods and visible elements in bulk.
Updates getEnvelopeChildFiles to use the new bulk formatter, eliminating N+1 queries when loading envelope children in initial state.
Unifies handling of envelope child files from both initial state and API responses. Adds fetchEnvelopeFiles helper and improves error handling for missing file URLs.
Checks isAuthenticated to use the appropriate endpoint:
- /sign/uuid/{uuid} for public/unauthenticated users
- /sign/file_id/{id} for authenticated users
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6541