[stable32] feat: optimize worker initialization #6555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces WorkerJobCounter class that counts pending SignFileJob and SignSingleFileJob instances using IJobList::countByClass(). This enables the worker system to make informed decisions about how many workers to start based on actual workload. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Changes worker stop_after parameter from 1h to 30m to reduce resource consumption and allow for more frequent worker refreshes. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Integrate WorkerJobCounter to check pending work before starting workers - Start only the minimum number of workers needed (min of pending jobs and desired workers) - Return early with 0 workers if no pending jobs exist - Rename constructor parameters to follow class naming convention - Extract business logic into self-documenting methods: * hasNoPendingWork(): checks if there are jobs to process * limitWorkersByAvailableWork(): calculates workers needed - Move WorkerHealthService to correct Worker namespace - Add isAsyncLocalEnabled() public method This reduces unnecessary worker spawning and improves resource efficiency. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Adds 8 test cases covering: - Zero pending jobs - Counting SignFileJob instances - Counting SignSingleFileJob instances - Summing both job types - Ignoring other job types - Exception handling - Empty array handling - Large number handling Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Adds test cases for: - No workers started when no pending jobs exist - Starting only needed workers based on pending job count - Limiting workers by both pending jobs and running workers - Starting fewer workers when less jobs than gap - Starting one worker when only one job pending - Proper handling when async local is disabled Updates all mock properties to follow class naming convention. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Update imports in SignFileController and FileProgressController to use the correct Worker namespace for WorkerHealthService after moving the class to lib/Service/Worker/ Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6551