[stable33] fix: signature elements without session #6559
Merged
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When background jobs execute signing operations for unauthenticated signers (e.g., via WhatsApp), they run in a different session context than when the visual elements were uploaded. This caused the system to fail finding the signature files, resulting in the error 'You need to define a visible signature or initials to sign this document.' The fix makes getNode() always attempt to retrieve files by nodeId using folderService->getFileByNodeId(), which searches across the entire signature folder tree regardless of session. Only if that fails does it fall back to session-based lookup for backward compatibility. This resolves signing failures for external signers who properly defined their visual signature elements. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add test coverage for the scenario where an unauthenticated signer (e.g., via WhatsApp) has uploaded signature elements that are stored in the folder service but accessed from a different session context during background job execution. This test verifies that the system can successfully locate and use signature files by their nodeId even when the session context differs from the upload context. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6557