Skip to content

[stable33] fix: html entities footer rendering#6967

Merged
vitormattos merged 4 commits intostable33from
backport/6966/stable33
Feb 19, 2026
Merged

[stable33] fix: html entities footer rendering#6967
vitormattos merged 4 commits intostable33from
backport/6966/stable33

Conversation

@backportbot-libresign
Copy link

Backport of PR #6966

Variables signedBy and validateIn are already escaped by htmlentities()
in FooterHandler. Adding |raw filter prevents Twig from escaping again,
which was causing HTML entities to appear literally in PDF footers.

Fixes #6961

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add DataProvider test with 14 scenarios covering:
- European languages (French, Portuguese, Spanish, German)
- Greek and Cyrillic alphabets
- RTL languages (Arabic, Hebrew)
- CJK scripts (Chinese, Japanese, Korean)
- Emoji and mixed character sets

Validates that accented characters and special Unicode render correctly
in PDF footers without HTML entity escaping.

Related to #6961

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add explicit comments warning translators not to translate mustache
template variables ({{variableName}}) in signature text strings.
This prevents corruption of template syntax during localization.

Discovered during investigation of #6961 where French translation
had corrupted mustache braces.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Feb 19, 2026
@backportbot-libresign backportbot-libresign bot added this to the Next Patch (33) milestone Feb 19, 2026
@vitormattos vitormattos merged commit 44d5cf2 into stable33 Feb 19, 2026
66 checks passed
@vitormattos vitormattos deleted the backport/6966/stable33 branch February 19, 2026 18:06
@github-project-automation github-project-automation bot moved this from 0. Needs triage to 4. to release in Roadmap Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

1 participant