[stable32] fix: files menu shortcut & icons#7340
[stable32] fix: files menu shortcut & icons#7340vitormattos merged 1 commit intoLibreSign:stable32from
Conversation
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
PS: you need to merge #7336 for the CI to pass. Not my fault here. |
45ad958 to
e4df98a
Compare
|
(rebased) |
…k signatures for stable32 Signed-off-by: Clément Christiaens <clement.christiaens@xwiki.com>
9bc1def to
2413e7a
Compare
|
I pushed a new fix on this branch by mistake, will open a new PR for it. |
|
@vitormattos the CI failure is not related to this PR. It's a bug in Unrelated to my changes, will not fix in this PR. Can someone review / merge? |
Nextcloud changed how the Files app calls file action callbacks between stable32 and master/stable33
Replaces #7318 for stable32 at least
Resolves: #7235
📝 Summary
LoadAdditionalListener loads libresign-init (which registers the file actions) but never provides the certificate_ok initial state. The enabled() check always returned false.
Also
enabled({ nodes })destructuring works on master (it pullsnodesout of the context object), but on stable32 the first argument is already the array itself, destructuring it for anodesproperty givesundefined.🧪 How to test
Also, there is the libresign icon applied for signed documents.
✅ Checklist