Skip to content

fix: handle visible signatures for envelope child files#7383

Merged
vitormattos merged 10 commits intomainfrom
fix/issue-7344-envelope-visible-signature
Apr 3, 2026
Merged

fix: handle visible signatures for envelope child files#7383
vitormattos merged 10 commits intomainfrom
fix/issue-7344-envelope-visible-signature

Conversation

@vitormattos
Copy link
Copy Markdown
Member

Summary

Testing

  • npm run ts:check
  • npm run test
  • docker compose exec -u www-data -w /var/www/html/apps-extra/libresign playwright npx playwright test playwright/e2e/sign-envelope-unauthenticated-visible-signature.spec.ts --output=/tmp/playwright-issue-7344-readable

Fixes #7344

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 3, 2026
…signature spec

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable33

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

…Engine spec

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos merged commit d7a49c8 into main Apr 3, 2026
69 checks passed
@github-project-automation github-project-automation bot moved this from 0. Needs triage to 4. to release in Roadmap Apr 3, 2026
@vitormattos vitormattos deleted the fix/issue-7344-envelope-visible-signature branch April 3, 2026 21:16
@backportbot-libresign
Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/7383/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fcb4aa9f 372b852a 57ef6b81 9e855f7f 007076c3 472a4e2f e50304ac 670104f3 0182377a 011a322a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7383/stable32

Error: Failed to push branch backport/7383/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/LibreSign/libresign.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

unauthenticated user cannot sign when multiple PDFs are in the sign request

1 participant