Add ThingSet via CAN ISO-TP #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gretel5X
approved these changes
Feb 25, 2021
|
Thanks for the review @Gretel5X. Fixed the issues and will merge after CI has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for ThingSet requests via CAN using lishen2/isotp-c library (forked to Libre Solar github account.
Firmware has been tested with Linux can-utils and MPPT 2420 HC charge controller using Zephyr implementation. The Zephyr implementation needs these additional features to support messages with padding.
As ISO-TP standard suggests fixed bytes (0xDA) for the bits 16..23, the ThingSet message format had to be changed such that the function code (first byte of a request) is included in the data and not in the ID. The ThingSet spec has to be updated accordingly.
Open points for proper implementation: