-
Notifications
You must be signed in to change notification settings - Fork 32
Core (LV::Video): Implement saves to PNG files #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hartwork Looks like I somehow confused the branches, lost the changes locally, then lost it from GitHub via a forced push. Is it still possible to recover it from GitHub? |
|
@kaixiong I'm optimistic that that can be fixed. A bit further up GitHub shows this: Following the link behind that compare button shows that the old commit still had PNG saving code in it. I think what you'll need for a fix is something like this: git checkout png-saves
git reset --hard c2b91ebffece693826fb3868ba1834a892285e6f
git push origin png-saves --force-with-leaseIf we did not have that help from GitHub, I'd try something like What do you think? |
c2b91eb to
72a6982
Compare
|
@hartwork Thanks, that seems to have worked. I hadn't realised there was a compare button in the GitHub timeline. Wonder what actually went down. |
|
@kaixiong good to see PNG saving back! 👍 |
ee46da1 to
ee33f7b
Compare
hartwork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaixiong found some time now, here's some minor things I found:
…into a common library.
hartwork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaixiong thanks for the adjustments! 👍

No description provided.