Change PNG image loader to load 8-bit indexed images without format conversion #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ideos with palette.
kaixiong
force-pushed
the
png-loader-no-8bit-to-rgb24-conversion
branch
from
547a31a to
a92641d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the PNG loader applies a libpng input transformation to convert 8-bit indexed colour images into 24-bit RGB images. This may be an undesirable step and inconsistent with what the BMP loader does.
This patch drops this and loads 8-bit indexed colour PNGs directly into 8-bit colour LV::Video objects. Note that 8-bit grayscale images continue to be converted to 24-bit RGB.