Validate API request security results before dispatch - #10
Draft
pH-7 wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API entrypoint currently overwrites failed authentication with success. This patch preserves the security result, rejects unexpected result shapes, and retains valid token responses. It also rejects malformed JSON without corrupting UTF-8 input, corrects the cache directory, and refreshes the stale Composer lock against PHP 7.4.
Validation: 28 offline request-dispatch checks; 18 PHP files pass syntax checks on PHP 8.5; isolated Composer resolution succeeds with no reported dependency advisories. Composer still warns about missing licence metadata.
This remains a draft: database/mobile-client integration is untested, and the legacy token protocol needs a separate account-ownership, expiry, recovery and shared-secret review before production use. No deployment is included.