fix: report vramFits=true for features already consuming VRAM#760
Merged
Lightheartdevs merged 1 commit intoLight-Heart-Labs:mainfrom Apr 3, 2026
Merged
Conversation
When a feature is enabled and running, its services consume VRAM, reducing free VRAM below the requirement threshold. This caused vramFits=false while enabled=true — contradictory. Now, when a feature is enabled, vramFits checks total VRAM instead of free. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Override
vramFitsto use total VRAM (not free VRAM) when a feature is already enabled and running.Why
The
/api/featuresendpoint computesvramFitsfrom free VRAM. When a feature is running, its services consume VRAM, reducing free VRAM below the feature's requirement. This producesvramFits=falsealongsideenabled=true— a contradictory signal that confuses users into thinking their hardware is insufficient for features already running successfully.How
In
calculate_feature_status(), after determiningis_enabled, if the feature is enabled, overridevram_fits = vram_ok(total VRAM >= requirement). A running feature has already "fit" — its own VRAM usage shouldn't count against it.The
vramFitsfield is informational only — it is not used in status determination logic (enabled,available,insufficient_vram,services_needed).Testing
python -m py_compilepassesReview
Critique Guardian verdict: ✅ APPROVED — correct logic, minimal diff, clear commentary.
Platform Impact