fix(dashboard-api): reject newlines and null bytes in env editor values#859
Merged
Lightheartdevs merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Sensitive Files DetectedTrigger: Security-sensitive files detected: .env Files flagged: Extra human review is recommended for this PR. Claude Code Review | Sensitive File Detection | ~$1.50 |
Adds validation in _serialize_form_values to reject values containing \n, \r, or \0. Prevents .env injection where a value like "3010\nINJECTED_KEY=malicious" could write an extra line to .env. Not exploitable in the current architecture (Docker Compose and Python dotenv treat values as literal strings), but closes a defense-in-depth gap identified during the #854 security audit. Adds 2 tests: newline injection rejected (400), null byte rejected (400). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fa6e20f to
0af6f0e
Compare
Sensitive Files DetectedTrigger: Security-sensitive files detected: .env Files flagged: Extra human review is recommended for this PR. Claude Code Review | Sensitive File Detection | ~$1.50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes a defense-in-depth gap in the env editor (#854). Rejects values containing
\n,\r, or\0to prevent .env injection.What was the gap
A submitted value like
3010\nINJECTED_KEY=maliciouswould write two lines to .env. Not exploitable in the current architecture (Docker Compose and Python dotenv treat it as a literal string), but a defense-in-depth gap.Fix
4 lines added to
_serialize_form_valuesinmain.py:Tests
test_api_settings_env_rejects_newline_in_value— submits3010\nINJECTED_KEY=malicious, asserts 400test_api_settings_env_rejects_null_byte_in_value— submits3010\x00injected, asserts 400🤖 Generated with Claude Code