update args & docs #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketmaurya
approved these changes
Dec 2, 2024
Contributor
aniketmaurya
left a comment
aniketmaurya
left a comment
There was a problem hiding this comment.
LGTM! Could have been broken into multiple simpler PRs though.
Borda
commented
Dec 2, 2024
ethanwharris
reviewed
Dec 2, 2024
Member
ethanwharris
left a comment
ethanwharris
left a comment
There was a problem hiding this comment.
Small nit. @Borda could you also link the feedback (assuming it's in notion somewhere) in the PR description please?
ethanwharris
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
following feedback with args order consistency and docstrings
ref: https://www.notion.so/lightningai/Aniket-Lightning-AI-15028e4762098062b917c4dbc73a7575
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃