Skip to content

test: improve mock readability #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Borda merged 2 commits into from
Dec 16, 2024
Merged

test: improve mock readability #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d908e2
test: mock SDK instead itself
Borda Dec 16, 2024
0bc612a
sdk_
Borda Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/litmodels/io/cloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
from typing import TYPE_CHECKING, List, Optional, Tuple, Union

from lightning_sdk.lightning_cloud.env import LIGHTNING_CLOUD_URL
from lightning_sdk.models import download_model, upload_model
from lightning_sdk.models import download_model as sdk_download_model
from lightning_sdk.models import upload_model as sdk_upload_model

if TYPE_CHECKING:
from lightning_sdk.models import UploadedModelInfo
Expand Down Expand Up @@ -71,7 +72,7 @@ def upload_model_files(
verbose: Whether to print a link to the uploaded model. If set to 0, no link will be printed.

"""
info = upload_model(
info = sdk_upload_model(
name=name,
path=path,
progress_bar=progress_bar,
Expand Down Expand Up @@ -99,7 +100,7 @@ def download_model_files(
Returns:
The absolute path to the downloaded model file or folder.
"""
return download_model(
return sdk_download_model(
name=name,
download_dir=download_dir,
progress_bar=progress_bar,
Expand Down
4 changes: 2 additions & 2 deletions tests/test_io_cloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_wrong_model_name(name):
(Module(), f"%s{os.path.sep}Module.pth", True),
],
)
@mock.patch("litmodels.io.cloud.upload_model")
@mock.patch("litmodels.io.cloud.sdk_upload_model")
def test_upload_model(mock_upload_model, tmpdir, model, model_path, verbose):
mock_upload_model.return_value.name = "org-name/teamspace/model-name"

Expand All @@ -44,7 +44,7 @@ def test_upload_model(mock_upload_model, tmpdir, model, model_path, verbose):
)


@mock.patch("litmodels.io.cloud.download_model")
@mock.patch("litmodels.io.cloud.sdk_download_model")
def test_download_model(mock_download_model):
# The lit-logger function is just a wrapper around the SDK function
download_model(
Expand Down
Loading