Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Dec 19, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

this was discovered while adding the integration test to litlogger as here the tests are mocked

TODO: we need to add integration tests!

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda merged commit 4216c38 into main Dec 19, 2024
32 checks passed
@Borda Borda deleted the fix/name branch December 19, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant