Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/ci-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,15 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-22.04", "macOS-13", "windows-2022"]
os: ["ubuntu-24.04", "macOS-13", "windows-2022"]
python-version: ["3.9", "3.12"]
requires: ["latest"]
dependency: ["lightning"]
include:
- { os: "ubuntu-20.04", python-version: "3.9", requires: "oldest" }
- { os: "ubuntu-22.04", python-version: "3.9", requires: "oldest", dependency: "lightning" }
- { os: "ubuntu-24.04", python-version: "3.10", requires: "latest", dependency: "pytorch_lightning" }
- { os: "ubuntu-24.04", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" }
- { os: "macOS-13", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" }

# Timeout: https://stackoverflow.com/a/59076067/4521646
timeout-minutes: 35
Expand All @@ -41,11 +45,23 @@ jobs:
pip install 'lightning-utilities[cli]'
python -m lightning_utilities.cli requirements set-oldest --req_files='["requirements.txt"]'

- name: Adjust requirements
run: |
pip install 'lightning-utilities[cli]' -U -q
python -m lightning_utilities.cli requirements replace-pkg \
--old_package="lightning" \
--new_package="${{matrix.dependency}}" \
--req_files='["_requirements/extra.txt"]'
cat _requirements/extra.txt

- name: Install package & dependencies
run: |
set -e
pip --version
pip install -e '.[test,extra]' -U -q --find-links $TORCH_URL
pip list
# check that right package was installed
python -c "import ${{matrix.dependency}}; print(${{matrix.dependency}}.__version__)"

- name: Tests with mocks
run: |
Expand Down
3 changes: 2 additions & 1 deletion src/litmodels/integrations/lightning_checkpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
from lightning.pytorch import Trainer
from lightning.pytorch.callbacks import ModelCheckpoint
elif _PYTORCHLIGHTNING_AVAILABLE:
from pytorch_lightning.callbacks import ModelCheckpoint, Trainer
from pytorch_lightning import Trainer
from pytorch_lightning.callbacks import ModelCheckpoint
else:
raise ModuleNotFoundError("No module named 'lightning' or 'pytorch_lightning'")

Expand Down
Loading