Skip to content

ckpt: rank_zero_only #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Borda merged 2 commits into from
Mar 13, 2025
Merged

ckpt: rank_zero_only #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2f0e26
ckpt: rank_zero_only
Borda Mar 12, 2025
1136061
lightning_utilities
Borda Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/litmodels/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = "0.1.1"
__version__ = "0.1.2rc"
__author__ = "Lightning-AI et al."
__author_email__ = "[email protected]"
__license__ = "Apache-2.0"
Expand Down
9 changes: 7 additions & 2 deletions src/litmodels/integrations/checkpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import Any, Type, TypeVar, cast

from lightning_sdk.lightning_cloud.login import Auth
from lightning_utilities.core.rank_zero import rank_zero_only

from litmodels import upload_model
from litmodels.integrations.imports import _LIGHTNING_AVAILABLE, _PYTORCHLIGHTNING_AVAILABLE
Expand Down Expand Up @@ -48,12 +49,16 @@ def __init__(self, model_name: str, *args: Any, **kwargs: Any) -> None:
except Exception:
raise ConnectionError("Unable to authenticate with Lightning Cloud. Check your credentials.")

def _save_checkpoint(self, trainer: Trainer, filepath: str) -> None:
super()._save_checkpoint(trainer, filepath)
@rank_zero_only
def _upload_model(self, filepath: str) -> None:
# todo: uploading on background so training does nt stops
# todo: use filename as version but need to validate that such version does not exists yet
upload_model(name=self.model_name, model=filepath)

def _save_checkpoint(self, trainer: Trainer, filepath: str) -> None:
super()._save_checkpoint(trainer, filepath)
self._upload_model(filepath)

return cast(Type[ModelCheckpointType], LitModelCheckpointTemplate)


Expand Down
Loading