uploading with queue on background #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/litmodels/integrations/checkpoints.py:207
- Duplicate definition of _remove_checkpoint detected; this may lead to maintenance challenges or ambiguous behavior. Please remove the redundant implementation.
def _remove_checkpoint(self, trainer: "pl.Trainer", filepath: str) -> None:
tchaton
approved these changes
Apr 4, 2025
| self.task_queue = queue.Queue() | ||
| self.upload_count = 0 | ||
| self.remove_count = 0 | ||
| self._worker = threading.Thread(target=self._worker_loop, daemon=True) |
Contributor
There was a problem hiding this comment.
How does it behaves with keyboard interruption ?
Contributor
Author
There was a problem hiding this comment.
this will likely continue
Contributor
There was a problem hiding this comment.
Yes, it should. But worth to see how it behaves in general. I think W&B still allows you to stop if you do multiple keyboard interrupt
justusschock
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
This pull request introduces an asynchronous model manager that processes upload and remove tasks in the background. By offloading these actions to a worker thread, it avoids blocking the training loop and achieves better resource utilization, ensuring that model performance or training speed is not impacted by file operations.
Additionally, the new approach uses a single queue but maintains separate counters for uploads and removals, making it simple to track task progress in each category. This design keeps the code streamlined and offers a clear way to monitor both types of background tasks while training.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃