-
Notifications
You must be signed in to change notification settings - Fork 8
test: validate scenario being in studio #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==================================
Coverage 89% 89%
==================================
Files 12 12
Lines 472 472
==================================
Hits 421 421
Misses 51 51 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/test_io_cloud.py:26
- [nitpick] The variable 'in_studio_only_name' could be renamed for clarity, e.g., 'isValidInStudio', to more clearly indicate its purpose.
in_studio_only_name = in_studio and name == "model-name"
tests/test_io_cloud.py:21
- [nitpick] The setup for the studio environment is repeated in both tests; consider refactoring this block into a helper function to reduce code duplication and improve maintainability.
if in_studio:
Before submitting
What does this PR do?
testing usecase when a user is running in lightning studio and the default teamspace can be loaded from env. variables
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃