Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Apr 14, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

testing usecase when a user is running in lightning studio and the default teamspace can be loaded from env. variables

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (1ac9424) to head (872ac59).
Report is 2 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #90   +/-   ##
==================================
  Coverage    89%   89%           
==================================
  Files        12    12           
  Lines       472   472           
==================================
  Hits        421   421           
  Misses       51    51           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda requested a review from Copilot April 14, 2025 16:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

tests/test_io_cloud.py:26

  • [nitpick] The variable 'in_studio_only_name' could be renamed for clarity, e.g., 'isValidInStudio', to more clearly indicate its purpose.
in_studio_only_name = in_studio and name == "model-name"

tests/test_io_cloud.py:21

  • [nitpick] The setup for the studio environment is repeated in both tests; consider refactoring this block into a helper function to reduce code duplication and improve maintainability.
if in_studio:

@Borda Borda enabled auto-merge (squash) April 14, 2025 19:57
@Borda Borda merged commit 3183ae3 into main Apr 14, 2025
40 checks passed
@Borda Borda deleted the test/in-studio branch April 14, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants