Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Apr 16, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This pull request introduces two new arguments to the model checkpointing logic to provide more control over local file cleanup behavior after uploading:

  • clear_all_local (bool):
    When set to True, remove all checkpoints after uploading to the cloud. This is useful when the models are too large and/or the machine has limited storage.
    Default behavior remains unchanged — local files are removed based on default CHepointing logic.

These changes improve flexibility for users and internal systems that need finer control over model persistence and cleanup strategies.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (5320a99) to head (12f5af5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #94   +/-   ##
==================================
  Coverage    89%   89%           
==================================
  Files        12    12           
  Lines       472   482   +10     
==================================
+ Hits        421   431   +10     
  Misses       51    51           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda changed the title feat: customised model cleaning feat: customised model cleaning / clear all local Apr 16, 2025
@Borda Borda marked this pull request as ready for review April 16, 2025 17:00
@Borda Borda merged commit 38eab58 into main Apr 16, 2025
41 checks passed
@Borda Borda deleted the feat/delete-models branch April 16, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants