Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Apr 17, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This pull request introduces two new arguments to the model checkpointing logic to provide more control over local file cleanup behavior after uploading:

  • keep_upload_all (bool):
    When set to True, all model versions/checkpoints are uploaded, and if checkointing logic perform local removal no version is removed from cloud. This is useful when users wish to preserve all models/versions in the cloud.

Default: number of local version and version in cloud is identical

These changes improve flexibility for users and internal systems that need finer control over model persistence and cleanup strategies.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90%. Comparing base (0eecc43) to head (7fe84c2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #98   +/-   ##
==================================
+ Coverage    89%   90%   +1%     
==================================
  Files        12    12           
  Lines       482   492   +10     
==================================
+ Hits        431   443   +12     
+ Misses       51    49    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda marked this pull request as ready for review April 17, 2025 10:17
@Borda Borda requested a review from aniketmaurya April 17, 2025 17:10
@Borda Borda merged commit a26d86d into main Apr 17, 2025
41 checks passed
@Borda Borda deleted the feat/delete-models-2 branch April 17, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants