Skip to content

Encapsulate multiprocessing communication#419

Merged
aniketmaurya merged 17 commits intomainfrom
aniket/facade-queue
Mar 10, 2025
Merged

Encapsulate multiprocessing communication#419
aniketmaurya merged 17 commits intomainfrom
aniket/facade-queue

Conversation

@aniketmaurya
Copy link
Copy Markdown
Collaborator

@aniketmaurya aniketmaurya commented Jan 20, 2025

What does this PR do?

  • Single interface for both ZMQ and multiprocessing queue for communication.
  • Either of them can be just replaced without any internal detail and without using if...else check for the type of communication.
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya marked this pull request as draft January 21, 2025 16:02
@aniketmaurya aniketmaurya changed the title [wip] Encapsulate multiprocessing communication Encapsulate multiprocessing communication Mar 9, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 79.54545% with 36 lines in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (1887fa2) to head (dabc735).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #419    +/-   ##
====================================
- Coverage    89%    89%    -1%     
====================================
  Files        32     37     +5     
  Lines      2052   2153   +101     
====================================
+ Hits       1832   1909    +77     
- Misses      220    244    +24     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aniketmaurya aniketmaurya marked this pull request as ready for review March 10, 2025 11:30
@aniketmaurya aniketmaurya merged commit 08a9caa into main Mar 10, 2025
21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/facade-queue branch March 10, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants