Skip to content

fix: reponse format JSONSchema key fix#427

Merged
aniketmaurya merged 3 commits intoLightning-AI:mainfrom
Lucaz0619:feat/reponse-format-bug-fix
Feb 13, 2025
Merged

fix: reponse format JSONSchema key fix#427
aniketmaurya merged 3 commits intoLightning-AI:mainfrom
Lucaz0619:feat/reponse-format-bug-fix

Conversation

@Lucaz0619
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes openai.BadRequestError 400 - missing required parameter related to response_format.json_schema.schema. The issue was caused by a naming mismatch in JSONSchema parsing when handling response formats. This is a simple fix that ensures proper parameter inclusion.

Before submitting
  • [x ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • [v] Did you read the contributor guideline, Pull Request section?
  • [v] Did you make sure to update the docs?
  • Did you write any new necessary tests?

How does this PR impact the user?

✅ Resolves incorrect request failures due to mismatch JSONSchema parameters.

Did you have fun?

Absolutely!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (ccc322a) to head (cfd1d3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #427   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        31     31           
  Lines      2025   2025           
===================================
+ Hits       1806   1811    +5     
+ Misses      219    214    -5     

@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Feb 13, 2025

Does it happen for and version or just the latest release?

@aniketmaurya aniketmaurya merged commit 49cedbd into Lightning-AI:main Feb 13, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants