Skip to content

Feat: add custom health check logic#430

Merged
aniketmaurya merged 12 commits intoLightning-AI:mainfrom
bhimrazy:feat/add-custom-health-check-logic
Feb 19, 2025
Merged

Feat: add custom health check logic#430
aniketmaurya merged 12 commits intoLightning-AI:mainfrom
bhimrazy:feat/add-custom-health-check-logic

Conversation

@bhimrazy
Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR introduces the ability to define custom health check logic in LitAPI, allowing users to tailor health checks to their specific needs.

Fixes #426.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (38b3559) to head (00f111d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #430   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        31     31           
  Lines      2030   2033    +3     
===================================
+ Hits       1808   1816    +8     
+ Misses      222    217    -5     

Copy link
Copy Markdown
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Few comments :)

Copy link
Copy Markdown
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @bhimrazy!

@aniketmaurya aniketmaurya merged commit b7e3f6f into Lightning-AI:main Feb 19, 2025
21 checks passed
@bhimrazy bhimrazy deleted the feat/add-custom-health-check-logic branch February 19, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow users to define a custom health check logic

3 participants