Skip to content

[wip]: debug windows threading issue#441

Closed
bhimrazy wants to merge 1 commit intoLightning-AI:mainfrom
bhimrazy:debug/windows-threading
Closed

[wip]: debug windows threading issue#441
bhimrazy wants to merge 1 commit intoLightning-AI:mainfrom
bhimrazy:debug/windows-threading

Conversation

@bhimrazy
Copy link
Copy Markdown
Collaborator

@bhimrazy bhimrazy commented Mar 2, 2025

What does this PR do?

Closes #385

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (90d7d10) to head (8e076e7).
Report is 40 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #441   +/-   ##
===================================
- Coverage    89%    89%   -0%     
===================================
  Files        31     31           
  Lines      2041   2028   -13     
===================================
- Hits       1824   1805   -19     
- Misses      217    223    +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Mar 4, 2025

is it related to #385?

@bhimrazy
Copy link
Copy Markdown
Collaborator Author

bhimrazy commented Mar 4, 2025

#385

yes @Borda

@aniketmaurya
Copy link
Copy Markdown
Collaborator

@bhimrazy how's it going here?

@bhimrazy
Copy link
Copy Markdown
Collaborator Author

@bhimrazy how's it going here?

Hey @aniketmaurya, sorry, I thought I had already mentioned it (my bad)! I did start working on this issue but had to pause since it requires a Windows device, and mine is currently under repair due to some part replacements. Hoping to get back to this issue soon!

@bhimrazy
Copy link
Copy Markdown
Collaborator Author

Closing this PR for now. I will reopen it or create a new one when I start working on it.

@bhimrazy bhimrazy closed this Apr 24, 2025
@bhimrazy bhimrazy deleted the debug/windows-threading branch April 24, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants