[wip]: debug windows threading issue#441
Closed
bhimrazy wants to merge 1 commit intoLightning-AI:mainfrom
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
===================================
- Coverage 89% 89% -0%
===================================
Files 31 31
Lines 2041 2028 -13
===================================
- Hits 1824 1805 -19
- Misses 217 223 +6 🚀 New features to boost your workflow:
|
Collaborator
|
is it related to #385? |
Collaborator
Author
Collaborator
|
@bhimrazy how's it going here? |
Collaborator
Author
Hey @aniketmaurya, sorry, I thought I had already mentioned it (my bad)! I did start working on this issue but had to pause since it requires a Windows device, and mine is currently under repair due to some part replacements. Hoping to get back to this issue soon! |
Collaborator
Author
|
Closing this PR for now. I will reopen it or create a new one when I start working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #385
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃