Skip to content

hotfix: pin starlette dependency#445

Merged
aniketmaurya merged 6 commits intoLightning-AI:mainfrom
bhimrazy:fix/tag-starlette
Mar 6, 2025
Merged

hotfix: pin starlette dependency#445
aniketmaurya merged 6 commits intoLightning-AI:mainfrom
bhimrazy:fix/tag-starlette

Conversation

@bhimrazy
Copy link
Copy Markdown
Collaborator

@bhimrazy bhimrazy commented Mar 4, 2025

What does this PR do?

This PR pins the Starlette dependency to avoid the 0.46.0 release.

Context:
The latest version of Starlette (0.46.0) has issues with pickling payload data—
specifically, the error cannot pickle '_io.BufferedRandom' object

The root cause of the error will be addressed in a separate PR shortly.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (90d7d10) to head (e99a5b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #445   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        31     31           
  Lines      2041   2041           
===================================
  Hits       1824   1824           
  Misses      217    217           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aniketmaurya aniketmaurya changed the title [wip]: add starlette dependency [wip]: pin starlette dependency Mar 4, 2025
@bhimrazy bhimrazy changed the title [wip]: pin starlette dependency hotfix: pin starlette dependency Mar 4, 2025
@bhimrazy bhimrazy marked this pull request as ready for review March 4, 2025 13:47
@bhimrazy bhimrazy requested a review from williamFalcon as a code owner March 4, 2025 13:47
@aniketmaurya aniketmaurya merged commit 3947e07 into Lightning-AI:main Mar 6, 2025
21 checks passed
@bhimrazy bhimrazy deleted the fix/tag-starlette branch April 3, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants