Skip to content

feat: add lightning cli dynamically #446

Merged
aniketmaurya merged 7 commits intomainfrom
aniket/connect-cli
Mar 6, 2025
Merged

feat: add lightning cli dynamically #446
aniketmaurya merged 7 commits intomainfrom
aniket/connect-cli

Conversation

@aniketmaurya
Copy link
Copy Markdown
Collaborator

@aniketmaurya aniketmaurya commented Mar 6, 2025

What does this PR do?

Let users run LitServe models using the Lightning CLI.

  • After SDK installation the litserve's lightning command is replaced from the SDK CLI.
image image
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (3947e07) to head (d0346d2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #446   +/-   ##
===================================
- Coverage    89%    89%   -0%     
===================================
  Files        31     32    +1     
  Lines      2041   2052   +11     
===================================
+ Hits       1824   1832    +8     
- Misses      217    220    +3     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aniketmaurya aniketmaurya merged commit f9be66d into main Mar 6, 2025
20 of 21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/connect-cli branch March 6, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants