Skip to content

fix: Starlette dependency issue#456

Merged
aniketmaurya merged 2 commits intoLightning-AI:mainfrom
deependujha:fix/starlette-version-issue
Mar 20, 2025
Merged

fix: Starlette dependency issue#456
aniketmaurya merged 2 commits intoLightning-AI:mainfrom
deependujha:fix/starlette-version-issue

Conversation

@deependujha
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #443

update max_file_size to spool_max_size

Starlette changed max_file_size name. check pr: Kludex/starlette#2780

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@deependujha deependujha changed the title fix: fix: Starlette dependency issue Mar 20, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (ec10c15) to head (1fb08ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #456   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        37     37           
  Lines      2153   2155    +2     
===================================
+ Hits       1909   1911    +2     
  Misses      244    244           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @deependujha 👏 ! thanks for the fix.

@aniketmaurya aniketmaurya merged commit c5ca70d into Lightning-AI:main Mar 20, 2025
21 checks passed
@deependujha deependujha deleted the fix/starlette-version-issue branch March 21, 2025 02:37
@bhimrazy
Copy link
Copy Markdown
Collaborator

Congratulations, @deependujha, on landing the first PR to LitServe! 🚀
Let's gooo 🔥🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot pickle '_io.BufferedRandom' object

4 participants