Skip to content

nitpick: minor refactoring#457

Merged
aniketmaurya merged 11 commits intoLightning-AI:mainfrom
deependujha:nitpick/minor-refactoring
Apr 3, 2025
Merged

nitpick: minor refactoring#457
aniketmaurya merged 11 commits intoLightning-AI:mainfrom
deependujha:nitpick/minor-refactoring

Conversation

@deependujha
Copy link
Copy Markdown
Contributor

What does this PR do?

nitpick: Refactors code with minor changes.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@deependujha deependujha changed the title nitpick: connector.py file nitpick: minor refactoring Mar 24, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (92d8115) to head (bd7f2cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #457   +/-   ##
===================================
- Coverage    89%    89%   -0%     
===================================
  Files        37     37           
  Lines      2155   2159    +4     
===================================
+ Hits       1911   1914    +3     
- Misses      244    245    +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aniketmaurya
Copy link
Copy Markdown
Collaborator

@deependujha please feel free to turn this ready to review whenever you feel it's ready.

@deependujha deependujha marked this pull request as ready for review April 3, 2025 03:52
@aniketmaurya aniketmaurya merged commit 74b67c6 into Lightning-AI:main Apr 3, 2025
21 checks passed
@deependujha deependujha deleted the nitpick/minor-refactoring branch April 3, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants