Skip to content

Add --local flag to lightning serve command in minimal_run.py#461

Merged
aniketmaurya merged 2 commits intomainfrom
aniket/use-local
Apr 2, 2025
Merged

Add --local flag to lightning serve command in minimal_run.py#461
aniketmaurya merged 2 commits intomainfrom
aniket/use-local

Conversation

@aniketmaurya
Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR adds the --local flag to the lightning serve command to ensure the server runs locally.

The command to run server has been changed from default local to opt-in to local so we need to add the --local argument.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (c83e0f5) to head (f6c7d4b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #461   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        37     37           
  Lines      2155   2155           
===================================
  Hits       1911   1911           
  Misses      244    244           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aniketmaurya aniketmaurya disabled auto-merge April 2, 2025 13:58
@aniketmaurya aniketmaurya merged commit 92d8115 into main Apr 2, 2025
21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/use-local branch April 2, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants