Skip to content

Move batch size to LitAPI#468

Merged
aniketmaurya merged 19 commits intomainfrom
aniket/move-batch-size-to-LitAPI
Apr 24, 2025
Merged

Move batch size to LitAPI#468
aniketmaurya merged 19 commits intomainfrom
aniket/move-batch-size-to-LitAPI

Conversation

@aniketmaurya
Copy link
Copy Markdown
Collaborator

@aniketmaurya aniketmaurya commented Apr 22, 2025

What does this PR do?

Batch size is closely attached to LitAPI for batched processing. LitServer doesn't make any use of this value.

Decoupling batch size and batch timeout from LitServer will help in enabling multiple endpoints with a cleaner architecture.

Old

api = LitAPI()
server = LitServer(api, max_batch_size=4)

New

(We still allow providing max_batch_size in LitServer with a deprecation warning - SS below)

api = LitAPI(max_batch_size=4)
server = LitServer(api)
image
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya changed the title Move batch size to LitAPI [wip] Move batch size to LitAPI Apr 22, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (509a301) to head (7cbece5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #468   +/-   ##
===================================
- Coverage    89%    89%   -0%     
===================================
  Files        37     37           
  Lines      2158   2163    +5     
===================================
+ Hits       1913   1917    +4     
- Misses      245    246    +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aniketmaurya aniketmaurya changed the title [wip] Move batch size to LitAPI Move batch size to LitAPI Apr 22, 2025
@aniketmaurya aniketmaurya requested a review from Borda April 24, 2025 12:04
@aniketmaurya aniketmaurya merged commit 028e9e0 into main Apr 24, 2025
21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/move-batch-size-to-LitAPI branch April 24, 2025 14:04
@aniketmaurya aniketmaurya mentioned this pull request May 13, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants