Skip to content

keep "minimal dependency CI" minimal#469

Merged
aniketmaurya merged 1 commit intomainfrom
aniket/minimal
Apr 22, 2025
Merged

keep "minimal dependency CI" minimal#469
aniketmaurya merged 1 commit intomainfrom
aniket/minimal

Conversation

@aniketmaurya
Copy link
Copy Markdown
Collaborator

What does this PR do?

The minimal dependency CI tests that LitServe can run error free with minimal dependency. Removing Lightning SDK command from the test which is causing the CI to freeze and will create a follow up to fix and test that separately.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (f456c51) to head (690d142).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #469   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        37     37           
  Lines      2158   2158           
===================================
  Hits       1913   1913           
  Misses      245    245           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aniketmaurya aniketmaurya merged commit 5478ece into main Apr 22, 2025
19 of 21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/minimal branch April 22, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants